Fix sample PPS report with longer poll intervals #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xdp_sample library functions were counting the total number of packets by adding the pps number regardless of the sample interval. If the interval is larger than one second, this leads to a miscount. Add a collection of functions that count packets instead of pps and use those for totals. Using an extra set of (trivial) helpers this way makes the call sites nicely symmetrical between pps and packet calculations. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
The sample_round() function does the same as the math lib round() function, so just use the library function instead. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
The interval is implied to be unsigned, but the variable is a regular int; change it to unsigned int to better reflect the semantics. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Instead of counting the number of rounds in the polling loop, actually calculate the total runtime in seconds and compute the average PPS from that. Also print the duration as part of the end-of-run statistics. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
The Summary line output was printing the total values instead of the PPS values, which led to wrong values being printed now that we account the total values correctly. Fix the output to print the PPS values instead of the totals. Add a new err_pps variable to stats_output.totals to record accumulated errors from the various count sources. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
|
I just did a quick test and the numbers are correct. Thanks @tohojo |
|
Great, thanks for testing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PPS values in xdp_sample output were calculated incorrectly if the reporting
interval is longer than one second. Fix this by reworking the accounting to
calculate packet and PPS values separately and printing the right values as
appropriate.