Fixes refined types applies: #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the requireConstant method in the body of the applies since the body is also inlined. - inline match for enums - constValue[T] for refined primitives (String)
dagmendez
commented
Oct 3, 2023
| inline if int < 0 | ||
| then error("Int must be positive.") | ||
| then error(codeOf(int) + " is negative. Int must be positive.") |
There was a problem hiding this comment.
Injects the rejected value in the error message.
dagmendez
commented
Oct 3, 2023
| else nonEmptyString | ||
| inline if constValue[Matches[nonEmptyString.type, "^\\S+$"]] | ||
| then nonEmptyString | ||
| else error(codeOf(nonEmptyString) + " is invalid. Empty String is not allowed here.") |
There was a problem hiding this comment.
Injects the rejected value in the error message.
dagmendez
commented
Oct 3, 2023
| @@ -154,10 +163,9 @@ object refinedTypes: | |||
| * More info at [[https://docs.scala-lang.org/scala3/reference/metaprogramming/inline.html]] | |||
| */ | |||
| inline def apply(nonEmptyString: String): NonEmptyString = | |||
| requireConst(nonEmptyString) | |||
| inline if nonEmptyString.isBlank | |||
There was a problem hiding this comment.
methods of the class java.String can not be inlined during compilation time.
dagmendez
commented
Oct 3, 2023
| inline if nonEmptyString.isBlank | ||
| then error("Empty String is not allowed here.") | ||
| else nonEmptyString | ||
| inline if constValue[Matches[nonEmptyString.type, "^\\S+$"]] |
There was a problem hiding this comment.
It evaluates at compile time if the string contains any character different than empty (blank, spaces, hidden characters...)
dagmendez
commented
Oct 3, 2023
| case "zstd" => zstd | ||
| case _: String => | ||
| error: | ||
| codeOf(kafkaCompressionType) + " is invalid.\nValid values are none, gzip, snappy, lz4 and zstd." |
There was a problem hiding this comment.
Injects the rejected value in the error message.
- Improves the logic for Inline apply for PositiveInt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apply methods of the refined types were broken since the bodies could not be inlined during "execution" time (in the console).