Implementation of Iron library #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set from Earliest to earliest
…ambiguous instances of the same types. Required forcing givens into local scope.
Comment on lines
+33
to
+34
| .setAppName(sparkProcessorConfiguration.app.appName.toString) | ||
| .setMaster(sparkProcessorConfiguration.app.masterUrl.toString) |
There was a problem hiding this comment.
toString can lead to some issues, as sometimes it is implemented with the hashcode or other stuff. Based on the specification, toString means a readable object string and shouldn't be treated as a value. Does that type have something like .value available?
There was a problem hiding this comment.
I have been iterating on this library at the client and .toString is also not recommended. There is a better use of the library. I will probably update this PR with the last team agreement. Soon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to reduce the boilerplate of the app by implementing the
ironlibrary.The reduction is visible in the total changes:
+168 −769