Skip to content

Commit

Permalink
Fix PHPUnit version constraints (#85)
Browse files Browse the repository at this point in the history
Also pin max tested version of HTMLPurifier to 4.17.0, because 4.18.0
removed support for conditional comments (ezyang/htmlpurifier@4828fdf).
  • Loading branch information
xemlock authored Feb 5, 2025
1 parent 0105fef commit 0a9dce5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
- name: Install dependencies
run: |
echo PHP_VERSION: ${{ env.PHP_VERSION }}
composer require --no-update ezyang/htmlpurifier:\<=4.17.0
composer install
- name: Run tests
Expand All @@ -57,3 +58,4 @@ jobs:
if [ -f "build/logs/clover.xml" ] && [ -f "vendor/bin/php-coveralls" ]; then
php vendor/bin/php-coveralls -v;
fi
continue-on-error: true
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"ezyang/htmlpurifier": "^4.8"
},
"require-dev": {
"phpunit/phpunit": ">=4.7",
"phpunit/phpunit": ">=4.7 <10.0",
"php-coveralls/php-coveralls": "^1.1|^2.1",
"masterminds/html5": "^2.7"
},
Expand Down

0 comments on commit 0a9dce5

Please sign in to comment.