Make it possible to create non-integer equal temperaments as cETs #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe think about how to inform the user about this. Should the input still be shown red on fractional divisions? |
|
The functionality works as expected for me, nice one! I haven't marked this as approved yet because I agree the user experience needs a tweak. Here's my take on it... |
|
Made the suggested changes. Also allowed cETs to be made using divisions less than 1. |
Disable relative steps and absolute degrees inputs when divisions is not an integer. ref #326
|
Self-reviewing: Seems legit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #326