Support primes as equaves in the lattice visualization #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostburn
force-pushed
the
lattice-prime-equaves
branch
3 times, most recently
from
021f85b
to
d9accfd
Compare
|
The direction of 2/1 keeps changing and causes confusion. Define new fixed coordinates that get zeroed out when the equave is an octave. |
frostburn
force-pushed
the
lattice-prime-equaves
branch
from
d9accfd
to
7330080
Compare
Define fixed coordinates for 2/1 when it's not the equave.
frostburn
force-pushed
the
lattice-prime-equaves
branch
from
7330080
to
64b73ca
Compare
|
Made 2/1 a bit longer. Prime lattices with various equaves look reasonably good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.