Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests against a generated project #2

Merged
merged 5 commits into from
Jan 17, 2022

Conversation

vierbergenlars
Copy link
Member

To verify the correct workings of the starters, add an integration test that will build a standard generated content-cloud project.

There are no modifications done to the generated project, so it can easily be replaced with a freshly generated copy.

Instead, a build in the integration-tests folder will grab the generated project and the main project and use them as included builds.
Using included builds automatically sets up dependency substitutions for the participating projects, and in addition we set up a configurable dependency substitution for the org.springframework.boot plugin itself, so we can test against different spring boot versions.

@tgeens
Copy link
Contributor

tgeens commented Jan 12, 2022

Integration tests fail because bintray (gradle plugins) is down again ?

@vierbergenlars
Copy link
Member Author

They were failing because bintray was down.

Now they are failing because the AWS SDK expects a region and throws when it does not have a region.
Is that something we can look to fix in the contentcloud-spring-boot-autoconfigure project? (which gets injected by the starter too)

@tgeens
Copy link
Contributor

tgeens commented Jan 13, 2022

Looks like it's a "missing feature" from the AWS SDK v2:

aws/aws-sdk-java-v2#2229 which points to aws/aws-sdk-java-v2#52
and we can conclude it's not getting fixed any time soon

So should we provide a default region ?

@vierbergenlars
Copy link
Member Author

Since endpoint is configurable, we can put a bogus region in if the endpoint is set or S3 is disabled (until paulcwarren/spring-content#667 is released).
Otherwise, we can read the region from a normal spring configuration variable and put it in the aws.region system property (that is read by s3)

@vierbergenlars vierbergenlars marked this pull request as ready for review January 13, 2022 17:42
@vierbergenlars vierbergenlars merged commit a77e6c4 into main Jan 17, 2022
@vierbergenlars vierbergenlars deleted the integration-tests branch January 17, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants