Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cosmetics #112

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

bernhardkaindl
Copy link
Collaborator

Fix pylint warning superfluous-parens (Unnecessary parens after 'not')

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
pylint does not know that six.raise_from(argument) re-raises the argument

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #112 (345a5df) into master (c734982) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   82.73%   82.72%   -0.02%     
==========================================
  Files          21       21              
  Lines        3371     3369       -2     
==========================================
- Hits         2789     2787       -2     
  Misses        582      582              
Flag Coverage Δ
unittest 82.72% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xcp/mount.py 58.33% <100.00%> (-0.86%) ⬇️
xcp/pci.py 86.51% <100.00%> (ø)
xcp/version.py 100.00% <100.00%> (ø)
xcp/xmlunwrap.py 96.22% <100.00%> (ø)

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl merged commit 541ff6b into xenserver:master Jul 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants