Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of simplejson #128

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

andyhhp
Copy link
Contributor

@andyhhp andyhhp commented Feb 12, 2024

This logic dates back to the XenServer 6.x days using Python 2.4.

simplejson was merged into the Python 2.5 standard library.

This logic dates back to the XenServer 6.x days using Python 2.4.

simplejson was merged into the Python 2.5 standard library.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feeb478) 83.25% compared to head (57d2eb4) 83.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   83.25%   83.44%   +0.18%     
==========================================
  Files          22       22              
  Lines        3363     3353      -10     
==========================================
- Hits         2800     2798       -2     
+ Misses        563      555       -8     
Flag Coverage Δ
unittest 83.44% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyhhp andyhhp merged commit 225656f into master Feb 12, 2024
9 checks passed
@andyhhp andyhhp deleted the private/andrewcoop/rm-simplejson branch February 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants