-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-46076 for XS9: To remove fcoe-utils, remove FCOE capabilty with LLDPAD tools from bugtool? #111
Conversation
@DeliZhangX: I added the explanation to CP-46076 why this change is not needed to remove the dependency on In fact, two of the tools that would no longer be called if this would be merged are not even in fcoe-utils: rpm -qf /usr/sbin/lldptool /usr/sbin/dcbtool
lldpad-1.0.1-10.xs8.x86_64
lldpad-1.0.1-10.xs8.x86_64 As I said in my explanation in CP-46076
Therefore, this change is not needed and would affect XS8Also, they would not target As I explained in my comment to CP-46076, the only change that you need to make to remove + %if 0%{?xenserver} < 9
Requires: fcoe-utils
+ %endif |
@@ -268,7 +266,6 @@ BIOSDEVNAME = 'biosdevname' | |||
BRCTL = 'brctl' | |||
CHKCONFIG = 'chkconfig' | |||
CHRONYC = 'chronyc' | |||
DCBTOOL = 'dcbtool' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only as a side note, for reference (obsolete) as this PR is not needed:
This package is not a file from fcoe-utils
:
rpm -qf /usr/sbin/dcbtool
lldpad-1.0.1-10.xs8.x86_64
@@ -286,7 +282,6 @@ IPTABLES = 'iptables' | |||
ISCSIADM = 'iscsiadm' | |||
KPATCH = 'kpatch' | |||
LIST_DOMAINS = 'list_domains' | |||
LLDPTOOL = 'lldptool' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only as a side note, for reference (obsolete) as this PR is not needed:
This package is not a file from fcoe-utils
:
rpm -qf /usr/sbin/lldptool
lldpad-1.0.1-10.xs8.x86_64
Because I added comments on other files, just to re-iterate: The only needed change for disabling the dependency of + %if 0%{?xenserver} < 9
Requires: fcoe-utils
+ %endif |
Thanks for your comments. |
Update:
This PR is not needed as explained in @bernhardkaindl's comment in CP-46076:
For removing
fcoe-utils
from XS9 as part of CP-46076, the only change is:The only needed change for disabling the dependency of
xenserver-status-report.rpm
onfcoe-utils
is to remove theRequires:
forfcoe-utils
for XS9 at line 32 inxenserver-status-report.spec
:PS: For further details, see the comment of @bernhardkaindl below. For example, this PR would also have removed the collection of other commands that are not part of
fcoe-utils
, but of LLDPAD: