CP-49680: Support unquoted values in /etc/xensource-inventory #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
ashwin9390
approved these changes
Jun 3, 2024
ashwin9390
approved these changes
Jun 3, 2024
bernhardkaindl
requested review from
qinz0822,
BengangY,
GeraldEV,
xueqingz and
gangj
liulinC
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xen-bugtoolarchive of the initial XenRT fail of CA-392173 was empty becausexen-bugtoolasserted on an empty value in/etc/xensource-inventory, where the management interface was not set for an unknown reason (maybe a DHCP failure during installation or so).This is not the cause of CA-392173, but
xen-bugtoolcan and should be able to collect the complete bug-report archive even in cases where/etc/xensource-inventorycontains unexpected data.CP-49680 has been opened to make
xen-bugtooltolerate unquoted strings by @xihuan-citrix:This PR implements CP-49680 to help to triage CA-392173 in order to create the expected bugtool data archive (in case CA-392173 triggers again).
The implementation is to just remove the assert for quoted strings and also remove the default value that enabled this assert (which was never used).
The 1st commit is already merged by #113, but this PR was opened including it and before #113 was merged: Only the 2nd commit is to be reviewed/approved here.