Ensure that filtering the xAPI DB keeps working for CP-41819 (Python3 Migration) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
liulinC
approved these changes
Oct 18, 2023
bernhardkaindl
requested review from
rosslagerwall,
lindig and
psafont
and removed request for
lindig
psafont
approved these changes
Oct 20, 2023
bernhardkaindl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Unit Test for the code filtering the private information from the xAPI DB.
It is a first quick step to ensure that the code filtering the xAPI DB works as expected,
and may be followed up with an integration test ensuring the proper integration of this code.
The GitHub CI workflow needed a few smaller fixes to work again:
if: ${{ matrix.python-version == 2.7 }}needs to be replaced because GitHub no longer has Python 2.7 in its Python matrix.pylintdidn't actually run, and its configuration is also in need of a small update to pass again on the current code.