CP-41819: Start py3 migration with config for isort and apply isort #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add .pyproject.toml with configuration for isort and line length - Add setup.cfg, enable `pip install .` with setuptools_scm - Apply isort changes as configured Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
requested review from
GeraldEV,
ashwin9390,
psafont and
rosslagerwall
psafont
approved these changes
Nov 3, 2023
GeraldEV
approved these changes
Nov 3, 2023
bernhardkaindl
deleted the
private/bernhardk/CP-41819-pip-pyproject-isort
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the the 1st PR to migrate to Python3:
Start off with a defined config and as most imports will have to be updated,
support the imports to be placed using
isortat the expected place.Changes:
pip install .with setuptools_scm