CA-390127: Fix adding even the last log() messages to the output archive #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## CP-48447/Py3-fix-abort-after-Exception-from-func_output #93 +/- ##
======================================================================================
Coverage 90% 90%
======================================================================================
Files 19 19
Lines 2230 2234 +4
======================================================================================
+ Hits 2011 2015 +4
Misses 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pull Request Test Coverage Report for Build 8368984611Details
💛 - Coveralls |
GeraldEV
approved these changes
Mar 21, 2024
bernhardkaindl
merged commit 7a7851a
into
xenserver:CP-48447/Py3-fix-abort-after-Exception-from-func_output
13 checks passed
bernhardkaindl
added a commit
to xenserver-next/status-report
that referenced
this pull request
Mar 21, 2024
…ive (xenserver#93) Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA-390127: Fix adding even the last log() messages to the output archive
The merge target of this PR is the same commit as in #92:
The reason for this is that this commit of #92 includes the needed unit test as the basis to verify this fix with an update to the unit test of #92.
Please review #92 as well, and after #92 is merged, I'll change the target of this PR to master (and I'll notify you for a final re-approval then)