CP-47521: Cleanup CAP_CVSM and StorageLink code (was removed in XS 6.5) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=====================================
+ Coverage 88% 91% +2%
=====================================
Files 18 19 +1
Lines 2196 2178 -18
=====================================
+ Hits 1939 1987 +48
+ Misses 257 191 -66
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pull Request Test Coverage Report for Build 8378240758Details
💛 - Coveralls |
GeraldEV
previously approved these changes
Mar 21, 2024
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
CP-47521/cleanup-XS6.5-removed-StorageLink-CVSM
branch
from
b4719ac
to
d6619b3
Compare
kc284
approved these changes
Mar 21, 2024
MarkSymsCtx
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of CA-357771 | Cleanup StorageLink / CVSM leftovers in bugtool and console
Clarified with Mark Syms:
Thus, we can go ahead and remove the CVSM / csl_logs code.
This obsoletes the need to test the Python3 changes to it: The dead code is gone for good.