fix: use dylib extension instead of jnilib for MacOS library names #939
Conversation
There was a problem hiding this comment.
we probably don't need that one
There was a problem hiding this comment.
The change does nothing indeed, but windows is unable to create the exact same binary twice due to embedded metadata like creation timestamps. I can revert the changes to the dlls if you want.
There was a problem hiding this comment.
I can revert the changes to the dlls if you want.
that's what i was implying. This PR should not modify those files.
There was a problem hiding this comment.
we probably don't need that one
There was a problem hiding this comment.
we probably don't need that one
There was a problem hiding this comment.
we probably don't need that one
There was a problem hiding this comment.
was that regenerated or just renamed ? file size has changed
There was a problem hiding this comment.
I renamed them initially, and then ran the CI to validate if they are still created correctly.
I don't know why the file size is different.
There was a problem hiding this comment.
can we keep the original file and just rename them in that case?
There was a problem hiding this comment.
I reverted the CI run, that should do it.
There was a problem hiding this comment.
was that regenerated or just renamed ? file size has changed
kkriske
force-pushed
the
change-jnilib-to-dylib
branch
from
1155cbf
to
f08e3a5
Compare
gotson
changed the title
copy from #922 (comment):
The libraries for MacOS are packaged as a .jnilib file. This seems legacy from pre java 7 (https://bugs.openjdk.org/browse/JDK-7134701). The default naming now seems to be .dylib.