Fixes clippy issues

xfbs · Oct 20, 2024 · 4c49a56 · 4c49a56
1 parent bece43d
commit 4c49a56
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/src/data.rs b/src/data.rs
@@ -300,7 +300,7 @@ impl CrateSource {
         }
 
         let prefix = format!("{}-{}/", version.krate, version.version);
-        let mut source = CrateSource {
+        let source = CrateSource {
             version,
             files: Self::parse_archive(&prefix, data, true)?,
         };
@@ -330,7 +330,7 @@ impl CrateSource {
             // make path encoding error explicit
             let bytes = entry.path_bytes();
             let path = std::str::from_utf8(&bytes)?;
-            let path = match path.strip_prefix(&prefix) {
+            let path = match path.strip_prefix(prefix) {
                 Some(path) => path,
                 None if error_outside_prefix => {
                     return Err(CrateSourceError::InvalidPrefix {
@@ -349,24 +349,19 @@ impl CrateSource {
 
             debug!("Storing path {path} ({} bytes)", data.len());
             // store data
-            files.insert(path.into(), data.into());
+            files.insert(path, data.into());
         }
 
         Ok(files)
     }
 
-    /// Add a single file to crate source.
-    fn add<T: Into<Bytes>>(&mut self, path: &Utf8Path, data: T) {
-        self.files.insert(path.into(), data.into());
-    }
-
     /// Get [`CargoVcsInfo`] from the crate sources.
     pub fn cargo_vcs_info(&self) -> Result<CargoVcsInfo, CargoVcsInfoError> {
         let raw = self
             .files
             .get(Utf8Path::new(".cargo_vcs_info.json"))
             .ok_or(CargoVcsInfoError::Missing)?;
-        let decoded = serde_json::from_slice(&raw)?;
+        let decoded = serde_json::from_slice(raw)?;
         Ok(decoded)
     }
 }

diff --git a/src/views/repo.rs b/src/views/repo.rs
@@ -5,7 +5,6 @@ use crate::{
     version::VersionId,
 };
 use camino::Utf8PathBuf;
-use log::*;
 use std::{rc::Rc, sync::Arc};
 use yew::{prelude::*, suspense::*};
 
@@ -118,7 +117,7 @@ fn CrateSourceFetcherInner(props: &CrateSourceFetcherProps) -> HtmlResult {
 
     let source = match &*source {
         Ok(source) => source.clone(),
-        Err(error) => {
+        Err(_error) => {
             return Ok(html! {
                 {"Error fetching source"}
             });
@@ -165,8 +164,6 @@ fn RepoSourceFetcher(props: &RepoSourceFetcherProps) -> Html {
         vcs_info,
     };
 
-    let url = info.url();
-
     let fallback = html! {
         {"Loading repository archive"}
     };