Skip to content

Conversation

@jskupsik
Copy link
Contributor

@jskupsik jskupsik commented Jan 21, 2026

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@jskupsik jskupsik changed the title Fixed error encountered when attempting to store.revert() on a stor… Fixed error on attempting to revert() on store with summary records Jan 21, 2026
@jskupsik
Copy link
Contributor Author

Fixed the following silent console error:
image

It occurred when users would cancel editing on a grid with a summary row via the store.revert() method.

Fixed to follow the documentation on StoreRecordConfig, as we were trying to "re-enhance" an already-frozen data object:

    /**
     * Data for this StoreRecord, pre-processed if applicable by `Store.processRawData()` and
     * `Field.parseVal()`. Note this must be a new object dedicated to this StoreRecord.
     * This object will be enhanced with an id and frozen.
     */
    data: PlainObject;

@jskupsik jskupsik requested review from amcclain and lbwexler January 21, 2026 00:51
Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@amcclain amcclain merged commit cdefef6 into develop Jan 21, 2026
2 checks passed
@amcclain amcclain deleted the revertSummaryRecordsBugFix branch January 21, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants