90: fix classroom card badge layout and add tooltips #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinaka
temporarily deployed
to
xi-development
GitHub Actions
Inactive
|
Contributor
Author
reinaka
temporarily deployed
to
xi-development
GitHub Actions
Inactive
unknownproperty
approved these changes
Jan 20, 2026
Contributor
unknownproperty
left a comment
unknownproperty
left a comment
There was a problem hiding this comment.
Всё хорошо, только стоит также новый пакет прописать для tailwind-конфига в index.css в xi.web
| type SubjectBadgePropsT = { | ||
| subject_id: number; | ||
| className?: string; | ||
| textStyles?: string; |
Contributor
There was a problem hiding this comment.
Чуть более лаконично: textClassName
| {classroom.subject_id ? ( | ||
| <SubjectBadge subject_id={classroom.subject_id} /> | ||
| <SubjectBadge | ||
| subject_id={classroom.subject_id} |
Contributor
There was a problem hiding this comment.
Я бы всё же в качестве стиля для написания пропса использовал camelCase
Это в целом не ошибка, но идеально использовать snake_case только для непосредственно полей из api, а тут мы уже работаем с пропсами самого компонента
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.