CORE - verify tx payload str #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2024 12:39
… the original transaction.
crosschainer
approved these changes
Oct 18, 2024
duelingbenjos
force-pushed
the
core-verify-tx-payload-str
branch
from
127f181
to
fb74bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the node receives a transaction, it deserialises the transaction JSON to a dict, part of this process is that small numbers (e.g 0.0000025) are converted to exponential notation. This is causing the signature verification step to fail when the transaction is not sent from python.
This fix changes the way the tx is handled - the
payloadis now extracted from the tx as a string, which is then used to verify the signature against.Additionally, this PR also includes the removal of some redundant verification steps - in finalise_tx and in check_tx (where it was being done twice.)
Type of change
Please delete options that are not relevant.
Checklist