Selectively Call Reflow on Component Update #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the reference equality check to compare previous
props
with the newprops
fails when new props are passed in that have the same values as the previous props,reflow
was getting called every time the component re-rendered, leading to a huge performance hit.By using LoDash's deep object equality comparison, we're able to eliminate unnecessary calls to
reflow
that are getting made whenprops
hasn't changed.Performance improvement:
On a page with 48 LinesEllipsis components already rendered, when I update the page to render an additional 24
LinesEllipses
components:LinesEllipses
components to screenLinesEllipses
components to screen