Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library Search : New event for list of providers, adjusted filter. #2386

Closed
wants to merge 2 commits into from
Closed

Library Search : New event for list of providers, adjusted filter. #2386

wants to merge 2 commits into from

Conversation

PeterMis
Copy link
Member

  • New event that returns an array of enabled library providers with their details (Pixabay as it stands)
  • Adjusted librarySearch provider filter to expect local, pixabay etc

@PeterMis PeterMis self-assigned this Feb 26, 2024
dasgarner
dasgarner reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment.

Also I think Mauro might want to pull this into his work so that we PR these at the same time (as these changes will break the UI)

lib/Controller/Library.php Outdated
}
} else {
// Dispatch event to get Providers and their details.
$eventList = new LibraryProviderListEvent();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do this? I think we ought to be able to just dispatch the LibraryProviderEvent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah I suppose we could just dispatch the LibraryProviderEvent with the provider 🤔
I'm not entirely sure why did this like that, let me remove the other event and some stuff

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, Removed the providersList event and the foreach/if, as we indeed don't need to do that there I don't think

dasgarner
dasgarner approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please check with Mauro before merging in case he wants to pull it in first.

@PeterMis
Copy link
Member Author

Merged as a part of this PR - #2398
As such I will close this one.

@PeterMis PeterMis closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasgarner dasgarner dasgarner approved these changes

@maurofmferrao maurofmferrao Awaiting requested review from maurofmferrao

Assignees

@PeterMis PeterMis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterMis @dasgarner