Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS: Use correct CAP name #2881

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

maurofmferrao
Copy link
Member

relates to xibosignageltd/xibo-private#919

@maurofmferrao maurofmferrao self-assigned this Jan 27, 2025
Copy link
Contributor

@nadzpogi nadzpogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Just one suggestion: please update the PHPDoc in the migration file as well (20240903142530_add_cap_connector_migration.php)

Copy link
Contributor

@nadzpogi nadzpogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@maurofmferrao
Copy link
Member Author

TEST: /login.cy.js END

Copy link

@maurofmferrao maurofmferrao merged commit ed98ac8 into develop Jan 28, 2025
3 checks passed
@maurofmferrao maurofmferrao deleted the bugfix/develop_cap_change_to_correct_name branch January 28, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants