-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New onboarding page #2889
New onboarding page #2889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some changes for the scope of CSS and code styling
</div> | ||
</div> | ||
{% endmacro %} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to remove the extra "new lines". Same for the CSS file.
web/theme/default/css/xibo.css
Outdated
right: 0; | ||
} | ||
|
||
html { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be careful with the scope of the CSS, since it's going to be applied to the whole CMS.
For smooth scroll, I think we can remove this and check later if we can do it with JS. For a class like .text-left
, we need to wrap with with the scope for the main container, like: .welcome-page .text-left
web/theme/default/css/xibo.css
Outdated
margin-top: auto; | ||
} | ||
|
||
.optional-link{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the CSS consistent, can we have a space between the rule and the curly bracket?
.optional-link {
instead of .optional-link{
Hi, @maurofmferrao! I made some new changes for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
TEST: login.cy.js END |
Test Suite: succeeded ✅ |
Applied new design for onboarding page.