Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New onboarding page #2889

Merged
merged 5 commits into from
Jan 30, 2025
Merged

New onboarding page #2889

merged 5 commits into from
Jan 30, 2025

Conversation

chaolen
Copy link
Contributor

@chaolen chaolen commented Jan 30, 2025

Applied new design for onboarding page.

@chaolen chaolen self-assigned this Jan 30, 2025
@chaolen chaolen requested a review from maurofmferrao January 30, 2025 12:43
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changes for the scope of CSS and code styling

</div>
</div>
{% endmacro %}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to remove the extra "new lines". Same for the CSS file.

right: 0;
}

html {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful with the scope of the CSS, since it's going to be applied to the whole CMS.
For smooth scroll, I think we can remove this and check later if we can do it with JS. For a class like .text-left, we need to wrap with with the scope for the main container, like: .welcome-page .text-left

margin-top: auto;
}

.optional-link{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the CSS consistent, can we have a space between the rule and the curly bracket?

.optional-link { instead of .optional-link{

@chaolen
Copy link
Contributor Author

chaolen commented Jan 30, 2025

Hi, @maurofmferrao! I made some new changes for this PR.

maurofmferrao
maurofmferrao previously approved these changes Jan 30, 2025
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@ifarzana
Copy link
Contributor

TEST: login.cy.js END

Copy link

@chaolen chaolen merged commit 1b52354 into develop Jan 30, 2025
2 checks passed
@chaolen chaolen deleted the features/new-onboarding-page branch January 30, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants