Various fixes related to Appstream data installation and ZSTD support #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the decompression finished, there can still be some data written to the output buffer. Without passing it over, the output can be cut.
The dash (`-`) is used in the appstream generated files, thus expect it. Related to ximion#683
ximion
requested changes
Feb 28, 2025
Some parts of the code know of `.yaml*`, but this one knows only about `.yml*`.
The code knows of .yml* and .yaml* variants on various places, this one was only missing. This fixes also a bug, when the YAML file was not compressed, it was treated as XML.
The repo data can be compressed with ZSTD, thus teach the as_utils_install_metadata_file() what to do with these files.
The as_utils_install_metadata_file() can install the .xml* data re-saved, with added origin reference. When it does so, and the original file was compressed, then the file name extension does not reflect the file content anymore (it's a pure XML after re-saving, not a compressed XML data). That can confuse the Appstream data readers, thus rename the file to be .xml, to avoid this problem.
mcrha
force-pushed
the
wip/various-fixes
branch
from
13283ab to
710755e
Compare
ximion
approved these changes
Mar 3, 2025
|
Thank you for the patch! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already the ZSTD compression support built in, but it was not extended into the appstream data installation, which is the place the code will reach it first, because the ZSTD can be used in the repositories.
See the respective commits for the various fixes done along the way.