Tvf cpp #1
Open
Tvf cpp #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 6e3fb5d...5c3eceb.
|
This change adds an extractor to traverse the Join plan and get lookup variables in different PlanNode, then stores the lookup variables in LookupJoinNode, which enables index lookup join with non-equal join condition for native execution. Additional changes are made to ensure lookup variables are not pruned by other optimizers.
Cherry-pick of trinodb/trino#80 Presto doesn't maintain the quotedness of an identifier when using SqlQueryFormatter so it results in throwing parsing error if quoted table name is a reserved word Co-authored-by: praveenkrishna <praveenkrishna@tutanota.com> Co-authored-by: imjalpreet <jalpreetnanda@gmail.com>
## Description 1. Extract the cleanup from prestodb#25242 ## Motivation and Context 1. clean up the codebase 2. separate concern from the original pr ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan 1. passed verifier test 2. ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
Summary: Support Max queued time limit. Queries queued for more than this threshold should fail with EXCEEDED_TIME_LIMIT error code and proper error msg Differential Revision: D78709808
Moves data previously stored in nested state objects or refs, to useState hooks. Adds concept of selected values to SqlDropdown component props. This allows react to properly/efficiently render state changes.
This updates the C++ standard to C++20 to match the Velox C++ standard.
With Velox PR 14103 the VELOX_ENABLE_GEO is off by default. PrestoC++ needs a method to enable the build of the GEO functions in the Velox submodule. Generally, this is called spatial functionality and, therefore, PRESTO_ENABLE_SPATIAL is introduced which enables VELOX_ENABLE_GEO.
…estodb#25242) ## Description TODO: Clean up the json field prestodb#25671 To keep the trunk cleaner and also move this pr forward, [we had a offline discussion and agree to update this pr with the following items](https://prestodb.slack.com/archives/C091L9VBAFR/p1752721296470699?thread_ts=1752715197.618069&cid=C091L9VBAFR): 1. Keep ConnectorSplit and ConnectorTransactionHandle in ConnectorCodecProvider. 2. Remove Hive implementation, in particular Hive*Split and Hive*TransactionHandle removing mixed JSON/Thrift support 3. Make ExecutionWriterTarget a Union and add support in `ConnectorCodecProvider` for related handles . 4. Deprecate MetadataUpdate. The original description: 1. Add thrift support for split and transaction handle 2. but only activated if the feature toggle is on and a proper connector specific codec is provided 3. **We will be using byte array for serialization for now and will iterate on the _interface definition within SPI_ to avoid unnecessary allocations for better performance.** 4. Instructions on how to use the thrift .idl file can be found in the [rfc](prestodb/rfcs#38). <img width="1035" height="427" alt="Screenshot 2025-07-16 at 07 58 01" src="https://github.com/user-attachments/assets/7f043ce7-7faa-43be-be8d-62d4ebdc81ee" /> 5. cpp side changes: prestodb#25595 ## Motivation and Context prestodb/rfcs#38 ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan 1. passed verifier run ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == General Changes * Improve efficiency of coordinator by supporting thrift codec for connector-specific data. ```
Summary: Make PrestoServer::driverExecutor_ abstract folly::Executor type. This is to provide flexibility to make driver executor customizable, for example, for monitoring. This change also makes other executors unique_ptr because PrestoServer as the application backing server, should hold sole ownership of all application related executors (in fact the current usage does not need any features from shared_ptr). Reviewed By: amitkdutta Differential Revision: D79155996
Earlier in MetadataManager.listTables used QualifiedObjectName that had a check for lowercase. Now, we can normalize identifer based on the connector, until specified in the connector, it would by default normalized to lowercase.
…5691) ## Description Fix broken unit test due to prestodb#25668 ## Motivation and Context Note: Google Test filter = PrestoToVeloxQueryPlanTest.parseIndexJoinNode [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from PrestoToVeloxQueryPlanTest [ RUN ] PrestoToVeloxQueryPlanTest.parseIndexJoinNode terminate called after throwing an instance of 'facebook::presto::protocol::OutOfRange' what(): [json.exception.out_of_range.403] key 'lookupVariables' not found IndexJoinNode List<VariableReferenceExpression> lookupVariables ## Impact No Impact. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
All code changes are made within the presto-spark-classloader-interface module. To support different implementations for spark2.4 and spark3.4, two separate modules have been created: presto-spark-classloader-spark2 and presto-spark-classloader-spark3. These modules contain the version-specific codes, including `PrestoSparkUtils`. It adds support for shuffle deserialize in `PrestoSparkShuffleSerializer`.
… and client tags (prestodb#25827) ## Description To support using custom storage access username based on source and client tags - Pass source and client tag from session to QueryConfig and QueryCtx - Abstract functions in PrestoServer, TaskManager, and QueryTextManager ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
This PR adds unit tests to be run for the arrow flight connector. Previously, only the end-to-end tests were run in the separate CI job. For regular CI build & test arrow flight is not enabled.
…s session property Fix prestodb#25651 Added description to docs for session property pushdown_subfields_for_map_functions
Update presto-docs/src/main/sphinx/admin/properties-session.rst Co-Authored-By: dongwang <mingwbd@gmail.com> Co-Authored-By: Steve Burnett <burnett@pobox.com>
…-identity transform
…estodb#25855) Summary: Currently this is hard coded and workers got detached at very early stage when there is still large amount of resources that could be used. Differential Revision: D80715227
Add three new columns : precision, scale and length Co-authored-by: Abdul Rashid Sinan C U <sinancu02@gmail.com> Co-authored-by: Nishitha Bhaskaran <nishithakbhaskaran@gmail.com>
This reverts commit 956978a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: