Add mechanism to handle completion of async res loads #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exter-N
commented
Jan 24, 2025
Comment on lines
+37
to
+38
| if (resource->LoadState != LoadState.Success) | ||
| return; |
There was a problem hiding this comment.
As I've implemented BeforeResourceComplete, this condition is redundant, because BRC doesn't fire for failed resources. I'm not sure what would make more sense between removing the condition here, and making BRC fire for failed res.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it work on my machine? - Apparently, yes.
Is it experimental? - Absolutely.
Do I have a clue what I'm doing? - Much less than it seems, I guess.
Requires Ottermandias/Penumbra.GameData#32