krb5: fix build & upgrade to 1.22.1 #8125
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Redbeanw44602, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the krb5 package to its latest stable version, 1.22.1. This update is essential for resolving existing build issues and improving compatibility with modern development environments, particularly concerning interactions with libraries that adhere to newer C standards. The change ensures a more robust and stable build process for krb5.
Highlights
- Version Upgrade: The krb5 package has been upgraded to version 1.22.1.
- Build Fix: The upgrade addresses build difficulties related to the previous 1.19.2 version's reliance on the gnu89 standard, which caused compatibility issues with newer libraries like OpenSSL.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request upgrades the krb5 package to version 1.22.1, resolving build issues present in the previous version, 1.19.2, especially concerning compatibility with newer libraries like OpenSSL. This is a positive change for the package's health. While this PR correctly addresses the krb5 issue, it's important to note a related concern: the openssl package dependency is on version 1.1.1, which is now End-of-Life and no longer receives security updates. I strongly recommend creating a follow-up PR to upgrade OpenSSL to a supported version, such as the 3.0.x LTS release, to mitigate potential security vulnerabilities.
| @@ -6,7 +6,7 @@ package("krb5") | |||
| add_urls("https://kerberos.org/dist/krb5/$(version).tar.gz", {version = function (version) | |||
| return format("%d.%d/krb5-%s", version:major(), version:minor(), version) | |||
| end}) | |||
| add_versions("1.19.2", "10453fee4e3a8f8ce6129059e5c050b8a65dab1c257df68b99b3112eaa0cdf6a") | |||
| add_versions("1.22.1", "1a8832b8cad923ebbf1394f67e2efcf41e3a49f460285a66e35adec8fa0053af") | |||
There was a problem hiding this comment.
For better maintainability, it would be helpful to add a comment explaining why version 1.19.2 was removed instead of just being deprecated. This provides valuable context for future developers, based on the information in your pull request description.
-- Version 1.19.2 was dropped due to build issues (gnu89) with newer libraries like openssl
add_versions("1.22.1", "1a8832b8cad923ebbf1394f67e2efcf41e3a49f460285a66e35adec8fa0053af")
Uh oh!
There was an error while loading. Please reload this page.