-
-
Notifications
You must be signed in to change notification settings - Fork 476
pango: update to 1.57.0 #8133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pango: update to 1.57.0 #8133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the Pango package definition to version 1.57.0. The primary goal is to incorporate the latest stable release of Pango, which likely brings new features, performance improvements, and bug fixes. The changes involve updating the version number and its corresponding integrity hash, as well as refining the source URL configurations to include GitHub as a primary download location.
Highlights
- Pango Version Update: The Pango library has been updated to version 1.57.0 in the
xmake.lua
configuration. - Source URL Configuration: New
add_urls
entries have been introduced to include GitHub as an alternative source for Pango, alongside the existing GitLab sources, ensuring more robust download options. - Version Hash Added: The SHA256 hash for Pango version 1.57.0 has been added to the
add_versions
list, ensuring integrity for the new package version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the pango
package to version 1.57.0. It correctly adds the new version and updates the source URLs to prioritize GitHub, as Pango has moved there. My review includes one suggestion to adjust the add_urls
calls to better align with the repository's conventions for defining source mirrors versus fallback sources, which will improve the robustness of package fetching.
add_urls("https://github.com/GNOME/pango/archive/refs/tags/$(version).tar.gz", | ||
"https://github.com/GNOME/pango.git") | ||
add_urls("https://gitlab.gnome.org/GNOME/pango/-/archive/$(version)/pango-$(version).tar.gz", | ||
"https://gitlab.gnome.org/GNOME/pango.git") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to xmake's packaging conventions, different types of sources (like tarball archives and git repositories) should be defined in separate add_urls
calls. Each call creates a source group, and multiple URLs within one call are treated as mirrors. A git repository is not a direct mirror of a versioned tarball.
To align with best practices seen in other packages in this repository (e.g., freetype
, harfbuzz
), please place each tarball and git URL in its own add_urls
call. This ensures a more predictable and robust fetching logic.
add_urls("https://github.com/GNOME/pango/archive/refs/tags/$(version).tar.gz")
add_urls("https://github.com/GNOME/pango.git")
add_urls("https://gitlab.gnome.org/GNOME/pango/-/archive/$(version)/pango-$(version).tar.gz")
add_urls("https://gitlab.gnome.org/GNOME/pango.git")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I maybe miss {alias = something}
Maybe Anubis gatekeeping (anti-DDoS) protection prevents to access to download for github actions, as it checks if it is bot coming up, so to workaround that first link should be github.com (mirror) not gitlab gnome.
To avoid double-linking same library we have to remove folder that provides meson-like dependencies.