Fix rustup package on Windows

[SirLynix]

xmake-io/xmake@8be13f8 broke rustup package because rustup-init relies on its filename.

D:\a\ShaderLang\xmake-global\.xmake\cache\packages\2509\r\rustup\1.28.1\rustup-1.28.1 --no-modify-path --no-update-default-toolchain --profile=minimal --default-toolchain=none -y
error: unknown proxy name: 'rustup-1.28'; valid proxy names are 'rustc', 'rustdoc', 'cargo', 'rust-lldb', 'rust-gdb', 'rust-gdbgui', 'rls', 'cargo-clippy', 'clippy-driver', 'cargo-miri', 'rust-analyzer', 'rustfmt', 'cargo-fmt'
error: .\.xmake-cache-W37\core\sandbox\modules\os.lua:378: execv(D:\a\ShaderLang\xmake-global\.xmake\cache\packages\2509\r\rustup\1.28.1\rustup-1.28.1 --no-modify-path --no-update-default-toolchain --profile=minimal --default-toolchain=none -y) failed(1)

[gemini-code-assist]

Summary of Changes

Hello @SirLynix, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug affecting the installation of the rustup package on Windows. The rustup-init executable requires a specific filename to function correctly, but a recent change inadvertently broke this. The fix ensures that the rustup-init installer is downloaded with its expected filename, thereby restoring the ability to properly set up the Rust toolchain within the xmake build system on Windows.

Highlights

• Windows rustup package fix: Corrected an issue where the rustup package failed to install on Windows because the rustup-init executable relies on its filename, which was not being preserved during download.
• Explicit filename specification: Modified add_urls calls in packages/r/rustup/xmake.lua to explicitly set the filename parameter for rustup-init.exe on Windows and rustup-init.sh on other platforms, ensuring the correct file name is used.
• Debugging aid: Added a temporary print statement to output the package:originfile() path during installation, likely for debugging the filename issue.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue with the rustup package on Windows by explicitly setting the installer's filename. This prevents rustup-init from misinterpreting its own versioned filename as an argument. The changes to add_urls are appropriate. I have one suggestion to remove a debugging statement that was likely left in by accident.

[star-hengxing]

I think we can only rename tarball(.tar/.zip) @waruqi

[waruqi]

xmake-io/xmake#6835

[SirLynix]

xmake-io/xmake#6835

note that in this case it's not about the extension, the executable runs but it fetches its own name because its the same binary for multiple executables (same as unzip iirc)

[waruqi]

xmake-io/xmake#6835

note that in this case it's not about the extension, the executable runs but it fetches its own name because its the same binary for multiple executables (same as unzip iirc)

This is only the case for special packages, so I still merged the patch.

But the extension also has problems and needs to be fixed.