Skip to content

Auto-update scons to 4.10.0 #8336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Auto-update scons to 4.10.0 #8336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/s/scons/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("scons")

add_urls("https://github.com/SCons/scons/archive/refs/tags/$(version).zip",
"https://github.com/SCons/scons.git")
add_versions("4.10.0", "2a68298875394fa6665f7ac360c682d846d2bdb786b54b4de785d7bd39c2b79e")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This automated version update introduces a potential issue. The on_install function contains patches and workarounds specific to older scons versions (e.g., lines 31-39 and 43). These may be incompatible with version 4.10.0, potentially causing build failures or incorrect behavior. For instance, the patch applied to SCons/Tool/masm.py on line 43 might not work with the new version. Such patches should be re-validated with each version bump to ensure compatibility.

add_versions("4.9.1", "074d8ceb95b6f0cbf91ec15ba087635cff0e9d06d02d0f838a852496781e8cc6")
add_versions("4.8.0", "2309f77eede26a494d697a18b6bb803ddb4ba20875091fb82da504a3665241cd")
add_versions("4.7.0", "c783ac12040d1682b81ffd153b48ac1dd9a0eff5a9fbfbb55d86c5d186e88e4a")
Expand Down
Loading