-
-
Couldn't load subscription status.
- Fork 487
Auto-update onnx to v1.19.1 #8423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest stable version of the ONNX (Open Neural Network Exchange) library, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the onnx package to version v1.19.1. The change is correct, adding the new version and its corresponding hash. I have one suggestion regarding the sorting of versions in the add_versions block to improve maintainability. The current auto-update script prepends the new version, which can lead to an unsorted list over time. It would be beneficial to address this in a follow-up.
| add_urls("https://github.com/onnx/onnx/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/onnx/onnx.git", {submodules = false}) | ||
|
|
||
| add_versions("v1.19.1", "ce9d2569a61d64e8a3d05b92194f60ffb7c868dbb754a71f5b4d992273a9413d") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this correctly adds the new version, the block of add_versions calls is not consistently sorted, which can make it harder to track version history and maintain the file. For better readability, it's a good practice to keep these version declarations sorted in descending order. This seems to be caused by the auto-update script, which just prepends the new version. A follow-up to sort the existing versions and perhaps adjust the script would be beneficial.
New version of onnx detected (package version: v1.18.0, last github version: v1.19.1)