Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 19, 2025

New version of onnx detected (package version: v1.18.0, last github version: v1.19.1)

@waruqi waruqi added the auto-update Automatic update label Oct 19, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the latest stable version of the ONNX (Open Neural Network Exchange) library, v1.19.1, into the package management system. This update ensures that projects utilizing this package can access the newest features, bug fixes, and performance enhancements provided by the updated ONNX specification, promoting compatibility and leveraging recent advancements in neural network model interchange.

Highlights

  • ONNX Version Update: The onnx package definition has been updated to include support for version v1.19.1, alongside its corresponding SHA-256 hash.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically updates the onnx package to version v1.19.1. The change is correct, adding the new version and its corresponding hash. I have one suggestion regarding the sorting of versions in the add_versions block to improve maintainability. The current auto-update script prepends the new version, which can lead to an unsorted list over time. It would be beneficial to address this in a follow-up.

add_urls("https://github.com/onnx/onnx/archive/refs/tags/$(version).tar.gz",
"https://github.com/onnx/onnx.git", {submodules = false})

add_versions("v1.19.1", "ce9d2569a61d64e8a3d05b92194f60ffb7c868dbb754a71f5b4d992273a9413d")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this correctly adds the new version, the block of add_versions calls is not consistently sorted, which can make it harder to track version history and maintain the file. For better readability, it's a good practice to keep these version declarations sorted in descending order. This seems to be caused by the auto-update script, which just prepends the new version. A follow-up to sort the existing versions and perhaps adjust the script would be beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants