[wgsl-validator] small fix with mingw on linux

[Kbz-8]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Kbz-8, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build configuration issue within the wgsl-validator package's xmake.lua file. It refines the platform detection for MinGW environments to ensure that the correct system libraries are linked, particularly when cross-compiling on a Linux host. This change aims to resolve potential linking errors and improve the robustness of the build process across different operating system and compiler combinations.

Highlights

• Refined MinGW Linking Logic: The build script's conditional logic for adding system links has been updated to correctly differentiate between MinGW environments running on Windows and those cross-compiling on Linux.
• Improved Cross-Compilation Support: A new condition was introduced to specifically handle MinGW cross-compilation on Linux hosts, ensuring the appropriate lowercase Windows system libraries (e.g., 'advapi32', 'user32') are linked for the wgsl-validator package.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a linking issue for MinGW cross-compilation on Linux by specifying lowercase library names. The logic is sound. I've provided a suggestion to refactor the conditional logic to avoid duplicating the list of system libraries, which will improve the code's maintainability.

[gemini-code-assist]

While your change correctly fixes the linking issue for MinGW on Linux, it introduces some code duplication for the list of Windows system libraries. To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, you could refactor this logic to define the list of libraries once and then adjust their casing based on the platform. This makes future updates to the library list easier and less error-prone.

    if is_plat("windows", "mingw") then
        local libs = {"Advapi32", "User32", "Userenv", "WS2_32", "RuntimeObject", "NtDll"}
        if is_plat("mingw") and is_host("linux") then
            for i, lib in ipairs(libs) do
                libs[i] = lib:lower()
            end
        end
        add_syslinks(unpack(libs))
    elseif is_plat("linux", "bsd") then
        add_syslinks("pthread")
    end