Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 20, 2025

New version of harfbuzz detected (package version: 11.3.3, last github version: 12.1.0)

@waruqi waruqi added the auto-update Automatic update label Oct 20, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs an automated update of the harfbuzz dependency to version 12.1.0. This update ensures that the project benefits from the latest features, performance improvements, and bug fixes available in the harfbuzz library, keeping the dependency current.

Highlights

  • Harfbuzz Version Update: The harfbuzz package has been automatically updated to its latest version, 12.1.0, from the previous 11.3.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically updates the harfbuzz package to version 12.1.0. The change is correct, and the SHA256 hash for the new version is valid. I've added one suggestion to improve the maintainability of the package file by refactoring the growing list of versions.

add_urls("https://github.com/harfbuzz/harfbuzz/archive/refs/tags/$(version).tar.gz", {excludes = "**/README", "**/test"})
add_urls("https://github.com/harfbuzz/harfbuzz.git")

add_versions("12.1.0", "0238bf7ada6b1fb92984f69f8b9cd66518af83cf24f7db1cfe60c772c42312d3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the addition of this new version, the list of add_versions calls is growing quite long. For better maintainability, consider moving this list to a separate file. You can see an example of this pattern in the libcurl package, which uses a versions.lua file to manage its version list. This would make the main package file cleaner and easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants