faiss: update to 1.12.0

[choyy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @choyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request upgrades the Faiss library to its latest version, 1.12.0, enhancing its build flexibility and feature set. It introduces comprehensive configuration options for various components like GPU support, MKL integration, Python bindings, and C API, allowing users to tailor the build to their specific needs. The update also refines dependency handling and modernizes the build process, ensuring compatibility and improved performance.

Highlights

• Faiss Version Update: The Faiss library has been updated to version 1.12.0, bringing the latest features and improvements.
• New Configuration Options: Introduced new build configuration options for GPU support, static GPU linking, MKL integration, Python bindings, C API, and Link-Time Optimization (LTO).
• Refined Dependency Management: The dependency resolution logic for CUDA, MKL, and OpenBLAS has been updated to be conditional based on the new configuration flags, allowing for more flexible builds.
• Modernized Build Process: The on_install hook now leverages the new configuration flags for CMake and removes previous hardcoded modifications to CMakeLists.txt, streamlining the build.
• C++ Standard Update: The C++ standard requirement for testing faiss::MultiIndexQuantizer has been updated from C++11 to C++17.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the faiss package to version 1.12.0 and significantly modernizes its xmake.lua script. The changes introduce much-needed configurability for features like GPU, MKL, Python, and C-API support, and expand platform compatibility. The dependency management has been improved, notably by making the CUDA dependency conditional. Overall, this is a great enhancement. However, I've found one critical issue in the MKL configuration logic that could lead to build failures, which I've detailed in a specific comment.

[gemini-code-assist]

The logic for enabling MKL is currently incorrect. It only checks package:config("mkl"), which defaults to true. If the MKL library is not found on the system, on_load correctly adds openblas as a fallback. However, on_install will still pass -DFAISS_ENABLE_MKL=ON to CMake. This will cause the build to fail because faiss's build system will be unable to find the MKL library.

The condition should also check if the MKL package is actually found using find_package("mkl") before enabling the corresponding CMake option.

        table.insert(configs, "-DFAISS_ENABLE_MKL=" .. (find_package("mkl") and package:config("mkl") and "ON" or "OFF"))

[waruqi]

please do not call find_package in on_load

[star-hengxing]

This is built-in config, you can check xrepo info zlib.