Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Added new webhook-schema package #204

Closed
wants to merge 6 commits into from
Closed

DRAFT: Added new webhook-schema package #204

wants to merge 6 commits into from

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented May 16, 2024 •
edited
Loading

Includes:

  • updated webhook-schema structs: RegistrationV1 and RegistrationV2
  • updated the validation to use webhook-schema options and removed the duplicate validation functionality from ancla

currently using local repos

MRs that need to be merged before this can be merged:

@maurafortino maurafortino requested a review from denopink May 16, 2024 20:03
@maurafortino maurafortino self-assigned this May 16, 2024
@maurafortino maurafortino marked this pull request as draft May 16, 2024 20:04
@guardrails GuardRails
Copy link

guardrails bot commented May 16, 2024 •
edited
Loading

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
Medium pkg:golang/github.com/aws/aws-sdk-go@v1.50.26 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink denopink changed the base branch from denopink/refactoring/remove-deprecated-webpa-common to main June 3, 2024 16:55
@maurafortino maurafortino mentioned this pull request Jun 24, 2024
Merged
@maurafortino maurafortino requested a review from piccione99 June 25, 2024 18:36
@maurafortino
Copy link
Contributor Author

Have a new PR for this based on the changes that were made to webhook-schema

@denopink denopink deleted the new-caduceus-test branch January 22, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink Awaiting requested review from denopink

@piccione99 piccione99 Awaiting requested review from piccione99

Assignees

@maurafortino maurafortino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maurafortino