Skip to content

Unit tests #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Unit tests #225

merged 9 commits into from
Jul 16, 2024

Conversation

maurafortino
Copy link
Contributor

Updated failing unit tests:

  • added tests for RegistrationV2 &RegistryV2
  • updated InternalWebhook & Webhook --> Registryv1 & RegistrationV1

Merge after: #222
Merge before: #223

@maurafortino maurafortino added the feature new functionality proposal/implementation label Jul 11, 2024
@maurafortino maurafortino requested a review from denopink July 11, 2024 15:03
@maurafortino maurafortino self-assigned this Jul 11, 2024
Copy link

guardrails bot commented Jul 11, 2024

⚠️ We detected 12 security issues in this pull request:

Hard-Coded Secrets (1)
Severity Details Docs
Medium Title: Github Key
uses: xmidt-org/shared-go/.github/workflows/ci.yml@f5dfcd47cad7a26a650c9639ad1e2f99c254b0e5 # v4.4.11
📚

More info on how to fix Hard-Coded Secrets in General.


Vulnerable Libraries (11)
Severity Details
High pkg:golang/github.com/xmidt-org/webhook-schema@v0.1.1-0.20240711140319-0ee06ff248b5 upgrade to: > v0.1.1-0.20240711140319-0ee06ff248b5
High pkg:golang/go.uber.org/fx@v1.22.0 upgrade to: > v1.22.0
High pkg:golang/github.com/xmidt-org/touchstone@v0.1.5 upgrade to: > v0.1.5
High pkg:golang/github.com/xmidt-org/urlegit@v0.1.12 upgrade to: > v0.1.12
High pkg:golang/github.com/prometheus/client_golang@v1.19.1 upgrade to: > v1.19.1
High pkg:golang/go.uber.org/multierr@v1.11.0 upgrade to: > v1.11.0
High pkg:golang/github.com/go-kit/kit@v0.13.0 upgrade to: > v0.13.0
High pkg:golang/github.com/xmidt-org/httpaux@v0.4.0 upgrade to: > v0.4.0
High pkg:golang/github.com/xmidt-org/argus@v0.9.13-0.20240711141248-1f7e75700ffb upgrade to: > v0.9.13-0.20240711141248-1f7e75700ffb
High pkg:golang/github.com/xmidt-org/bascule@v0.11.6 upgrade to: > v0.11.6
High pkg:golang/github.com/stretchr/testify@v1.9.0 upgrade to: > v1.9.0

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino mentioned this pull request Jul 11, 2024
@maurafortino maurafortino changed the base branch from denopink/refactoring/remove-deprecated-webpa-common to feat/webhook-update July 16, 2024 13:39
Copy link

guardrails bot commented Jul 16, 2024

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
High pkg:golang/github.com/xmidt-org/urlegit@v0.1.12 upgrade to: > v0.1.12

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

I left a few questions, I'll approve once they're answered

Copy link

guardrails bot commented Jul 16, 2024

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
High pkg:golang/github.com/xmidt-org/urlegit@v0.1.12 upgrade to: > v0.1.12

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino merged commit 584683d into feat/webhook-update Jul 16, 2024
12 of 15 checks passed
@maurafortino maurafortino deleted the unit-tests branch July 16, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality proposal/implementation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants