Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measures update #259

Closed
wants to merge 1 commit into from
Closed

Measures update #259

wants to merge 1 commit into from

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Nov 7, 2024

What's Included:
small fix to the MeasuresIn struct - was failing in tr1d1um due to the cyclic nature of NewMeasures

removed Measures struct from MeasuresIn and replaced it with the Measures that we create in the step before NewMeasures

@maurafortino maurafortino added the bug Something isn't working label Nov 7, 2024
@maurafortino maurafortino requested a review from denopink November 7, 2024 21:24
@maurafortino maurafortino self-assigned this Nov 7, 2024
@maurafortino maurafortino changed the base branch from main to feat/webhook-update November 7, 2024 21:25
Copy link

guardrails bot commented Nov 7, 2024

⚠️ We detected 5 security issues in this pull request:

Vulnerable Libraries (5)
Severity Details
High pkg:golang/go.uber.org/fx@v1.22.1 upgrade to: > v1.22.1
High pkg:golang/github.com/xmidt-org/webhook-schema@v0.1.1-0.20240718124820-b8c1ba1f19a9 upgrade to: > v0.1.1-0.20240718124820-b8c1ba1f19a9
High pkg:golang/github.com/xmidt-org/touchstone@v0.1.5 upgrade to: > v0.1.5
Medium pkg:golang/github.com/aws/aws-sdk-go@v1.54.19 - no patch available
High pkg:golang/github.com/xmidt-org/urlegit@v0.1.12 upgrade to: > v0.1.12

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink
Copy link
Contributor

denopink commented Nov 7, 2024

closing in favor of #260

@denopink denopink closed this Nov 7, 2024
@maurafortino maurafortino deleted the measures-update branch November 21, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants