Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce ancla's auth interface #272

Closed
wants to merge 2 commits into from

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Jan 8, 2025

- once #271 is merged, `chrysom/acquire` will replace `bascule`
- `chrysom/acquire` will allow the user to provide there own auth implementation instead of ancla relying on `bascule`
- `chrysom/acquire` will be integrated once #271 is merged
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Jan 8, 2025
@denopink denopink self-assigned this Jan 8, 2025
@denopink
Copy link
Contributor Author

denopink commented Jan 8, 2025

will introduce the auth interface in a later pr

@denopink denopink closed this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (35dae74) to head (469d991).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files          18       18           
  Lines         890      890           
=======================================
  Hits          735      735           
  Misses        130      130           
  Partials       25       25           
Flag Coverage Δ
unittests 82.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink deleted the denopink/feat/auth-interface branch January 8, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant