Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove sallust dependency #274

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Jan 14, 2025

  • removed sallust dependency
  • removed config.Logger == nil checks and they'll be replaced with client config options in the near future

@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Jan 14, 2025
@denopink denopink self-assigned this Jan 14, 2025
@denopink denopink force-pushed the denopink/refactor/remove-sallust-dependency branch from ea8c5ea to acd66b5 Compare January 14, 2025 17:18
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (e259449) to head (6edbd7e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files          19       19           
  Lines         808      808           
=======================================
  Hits          673      673           
  Misses        117      117           
  Partials       18       18           
Flag Coverage Δ
unittests 83.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink force-pushed the denopink/refactor/remove-sallust-dependency branch from 449e519 to 8abaddb Compare January 14, 2025 20:19
- removed sallust dependency
@denopink denopink force-pushed the denopink/refactor/remove-sallust-dependency branch from 8abaddb to 6edbd7e Compare January 14, 2025 20:24
@denopink denopink merged commit 55bf050 into main Jan 14, 2025
17 checks passed
@denopink denopink deleted the denopink/refactor/remove-sallust-dependency branch January 14, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants