Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role based access support in dynamo db #770

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ChaitanyaSingla
Copy link
Contributor

This pull request introduces IAM-based access for DynamoDB functionality. The AWS SDK will now automatically retrieve the secret access key, access key ID and session token from the appropriate chain provider based on the specified AWS region. This retrieval is for the assumed role attached to the service's instance.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2024

CLA assistant check
All committers have signed the CLA.

@Sachin4403
Copy link
Contributor

@schmidtw
Please review and merge this pull request.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 47.28%. Comparing base (9e9d66c) to head (8edc241).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
store/dynamodb/db.go 0.00% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #770       +/-   ##
===========================================
- Coverage   63.46%   47.28%   -16.19%     
===========================================
  Files          18       28       +10     
  Lines        1300     1453      +153     
===========================================
- Hits          825      687      -138     
- Misses        455      746      +291     
  Partials       20       20               
Flag Coverage Δ
unittests 47.28% <0.00%> (-16.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw merged commit 4d1e26b into xmidt-org:main Sep 3, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants