Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webhook URI in latency metric of the outbound sender #323

Closed
wants to merge 2 commits into from

Conversation

chaitanyasingla-dt
Copy link

There has been an addition in caduceus to track latency metrics for outbound senders.

Scenario:
Let's suppose we have multiple webhooks getting tracked and only one of them is increasing the latency of the request. If all the webhooks latency metric is getting tracked under the same name that is code = strconv.Itoa(resp.StatusCode), we will not be able to identify the source of the increase in latency of the requests.

Solution:
This pull request adds Webhook URI to the latency metric to identify the source of the increase in the latency of the requests.

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.66%. Comparing base (6241ccb) to head (c6ba0cc).
Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   66.58%   66.66%   +0.07%     
==========================================
  Files          10       10              
  Lines        1293     1296       +3     
==========================================
+ Hits          861      864       +3     
  Misses        403      403              
  Partials       29       29              
Flag Coverage Δ
unittests 66.66% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink
Copy link
Contributor

work completed in #461 , the duration metric will now have a url label

@denopink denopink closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants