Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #445

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Tests #445

merged 4 commits into from
Mar 28, 2024

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Jan 25, 2024

What's Included:

  • added tests for metrics
  • added tests for main
  • updated code to fix failing tests

Should be reviewed/merged after merging #444

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9ae064c) 7.99% compared to head (49f2c98) 32.64%.
Report is 3 commits behind head on denopink/feat/rewrite.

Files Patch % Lines
http.go 0.00% 11 Missing ⚠️
httpClient.go 0.00% 2 Missing ⚠️
senderWrapper.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           denopink/feat/rewrite     #445       +/-   ##
==========================================================
+ Coverage                   7.99%   32.64%   +24.65%     
==========================================================
  Files                         12       12               
  Lines                       1214     1216        +2     
==========================================================
+ Hits                          97      397      +300     
+ Misses                      1117      807      -310     
- Partials                       0       12       +12     
Flag Coverage Δ
unittests 32.64% <40.00%> (+24.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

guardrails bot commented Jan 25, 2024

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink denopink merged commit 1dc32f3 into denopink/feat/rewrite Mar 28, 2024
16 checks passed
@denopink denopink deleted the tests branch March 28, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants