Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sink interface #476

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Apr 8, 2024

  1. sinkwrapper client interface will be replace by the sink interface
  2. the sink interface will have the following funcs (update(l Listener), send(urls *ring.Ring, secret, acceptType string, msg *wrp.Message))
  3. the webhook abstraction will be renamed to something like matcher since it's main purpose is to match incoming messages to desired events or wrp field regex

Copy link

guardrails bot commented Apr 8, 2024

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink denopink changed the base branch from denopink/feat/rewrite to main April 9, 2024 14:24
@denopink denopink changed the base branch from main to denopink/feat/rewrite April 9, 2024 14:24
sink.go Outdated Show resolved Hide resolved
sink.go Outdated Show resolved Hide resolved
sinkSender.go Outdated Show resolved Hide resolved
sinkSender.go Outdated Show resolved Hide resolved
sinkSender.go Outdated Show resolved Hide resolved
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
left some suggestions

@maurafortino maurafortino merged commit 03f7c9b into denopink/feat/rewrite Apr 9, 2024
10 of 14 checks passed
@maurafortino maurafortino deleted the feat/sink-interface branch April 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants