Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated package structure to include internal package #478

Merged
merged 4 commits into from
Apr 15, 2024
Merged

updated package structure to include internal package #478

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4138bf5
updated package structure to include internal package
maurafortino Apr 10, 2024
c20a5b3
rebases/fixed merge conflicts
maurafortino Apr 10, 2024
548aaad
made PR review edits
maurafortino Apr 11, 2024
828166a
package-reorg
maurafortino Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebases/fixed merge conflicts
  • Loading branch information
@maurafortino
maurafortino committed Apr 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit c20a5b3659ec9e3be46087e9af361cf84b524944
5 changes: 2 additions & 3 deletions internal/sink/sink.go
View file
Original file line number Diff line number Diff line change
@@ -14,7 +14,6 @@ import (
"strings"
"time"

"github.com/xmidt-org/caduceus/internal/client"
"github.com/xmidt-org/caduceus/internal/metrics"
"github.com/xmidt-org/retry"
"github.com/xmidt-org/retry/retryhttp"
@@ -33,9 +32,9 @@ type WebhookV1 struct {
deliveryInterval time.Duration
deliveryRetries int
logger *zap.Logger
//TODO: need to figure out best way to add client and middleware to webhook
//TODO: need to determine best way to add client and client middleware to WebhooV1
client http.Client
clientMiddleware func(client.Client) client.Client
clientMiddleware func(http.Client) http.Client
}

func NewWebhookV1(s *SinkSender) {
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.