Subscription: Configuration options response handled. Fixes #5

lib/pubsub.js

@@ -149,7 +149,9 @@ PubSub.prototype.subscribe = function(data, callback) {
         var details = { subscription: subscription.attrs.subscription }
         var options
         if (options = subscription.getChild('subscribe-options'))
-            details.configuration = { required: (true == options.getChild('required')) }
+            details.configuration = { 
+                required: (null != options.getChild('required'))
+            }
         if (subscription.attrs.subid) details.id = subscription.attrs.subid
         callback(null, details)
     })

test/lib/pubsub.subscribe.js

@@ -142,6 +142,27 @@ describe('Publish-Subscribe', function() {
                 callback
             )
         }) 
+
+        it('Handles configuration required', function(done) {
+            xmpp.once('stanza', function(stanza) {
+                manager.makeCallback(helper.getStanza('subscribe-options'))
+            })
+            var callback = function(error, success) {
+                should.not.exist(error)
+                success.configuration.required.should.be.true
+                done()
+            }
+            var request = {
+                to: 'pubsub.shakespeare.lit',
+                node: 'twelfth night'
+            }
+            socket.emit(
+                'xmpp.pubsub.subscribe',
+                request,
+                callback
+            )
+        })
+
     })
 
 })

test/resources/subscribe-options

@@ -0,0 +1,15 @@
+<iq type='result'
+    from='pubsub.shakespeare.lit'
+    to='juliet@example.net/balcony'
+    id='1'>
+  <pubsub xmlns='http://jabber.org/protocol/pubsub'>
+    <subscription
+        node='twelfth night'
+        jid='juliet@example.net'
+        subscription='subscribed'>
+      <subscribe-options>
+        <required/>
+      </subscribe-options>
+    </subscription>
+  </pubsub>
+</iq>