-
Notifications
You must be signed in to change notification settings - Fork 20
AgentsSDK 2.0.0 + Skills #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all example packages to use agent-sdk 2.0.0-rc3 from root - Fix xmtp-attachments: Update EncryptedAttachment API (payload instead of content.payload) - Fix xmtp-gated-group: Use agent.createGroupWithAddresses instead of conversations.newGroup - Fix xmtp-thinking-reaction: Use ReactionSchema enum and ctx.sendReaction - Fix xmtp-generalstore: Import ActionStyle from @xmtp/node-sdk correctly - Fix utils/inline-actions: Import ActionStyle as value, not type - Update sendRemoteAttachment to use ctx.sendRemoteAttachment - All builds passing, lint warnings only (no errors)
…ndWelcomeMessage type
- Add 8 skills with 30 rule files covering core XMTP patterns - Skills: agent-basics, commands, inline-actions, attachments, transactions, groups, reactions, domain-resolver - Remove .cursor/rules/ (content moved to skills/) - Update README with skills listing and installation instructions - Add AGENTS.md with AI agent guidelines
- Remove Related examples sections from all skills - Remove lib/ bundled code directories (skills can't import) - Add implementation snippets directly in SKILL.md files - Update code examples to remove prescriptive import paths - Skills now show patterns and how to implement helpers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-evaluating approvability for fde0501
Skills are now in the correct location for Cursor to automatically discover and use them as AI context.
.cursor/skills/handling-transactions/rules/receive-transaction-reference.md
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade examples and docs to
@xmtp/agent-sdk2.0.0 and switch message APIs toMessageContext.conversation.sendText/sendActions/sendMarkdown/sendWalletSendCallsacross example handlersBumps SDK to 2.0.0, replaces deprecated
ctx.sendTextand genericconversation.sendcalls with conversation-specific send methods, refactors inline actions to use@xmtp/node-sdk, updates attachments toctx.sendRemoteAttachmentanddownloadRemoteAttachment, and adds/refreshes repository documentation and changelog.📍Where to Start
Start with SDK usage changes in
Agent.createFromEnvand handler message sends in examples/xmtp-generalstore/index.ts, then review inline actions refactor in utils/inline-actions.ts and attachment handling in examples/xmtp-attachments/index.ts.📊 Macroscope summarized fde0501. 50 files reviewed, 20 issues evaluated, 1 issue filtered, 1 comment posted
🗂️ Filtered Issues
examples/xmtp-gated-group/index.ts — 0 comments posted, 1 evaluated, 1 filtered
ctx.message.senderInboxId(line 57), but the handler adds users to the set usingctx.getSenderAddress()(line 141). The switch fromagent.client.conversations.newGroup(V2) toagent.createGroupWithAddresses(V3/Agent SDK) in the diff at line 127 implies a context wheresenderInboxId(Identity) andsenderAddress(Wallet) are distinct values. Consequently,usersInGroup.has(senderInboxId)will returnfalseeven afterusersInGroup.add(senderAddress)is called, causing state loss. This allows users to bypass the validation and repeatedly trigger the group creation flow. [ Already posted ]