Remove pipes module on versions > 3.3. #22
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipes is deprecated as of [3.11](https://peps.python.org/pep-0594/) and is set to be removed in 3.13. The `shlex` module introduced a `quote` function in 3.3 and the `pipes` module adopted it at the same time. I performed the import in such a way as to continue to use the pipes.quote when it wasn't just a wrapper around shlex.quote.
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pipesmodule is deprecated as of 3.11 and is set to be removed in 3.13.The
shlexmodule introduced aquotefunction in 3.3 and thepipesmodule adopted it at the same time.I performed the import in such a way as to continue to use the
pipes.quotewhen it wasn't just a wrapper aroundshlex.quote. (Working under the assumption that you'd like to keep support for older versions.)I also added newer Python versions to the PyPi
classifiersand to the Travis config.Let me know if there's anything you'd like to adjust (you also have edit permissions on the PR
¯\_(ツ)_/¯).I recognize this is similar to #21. The main difference is that this change supports all Python versions.