Replace null checks with IsEmpty property for ReadOnlySpan<char> #916
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suppresses CA2265 warnings.
There was a problem hiding this comment.
Pull request overview
This PR aims to replace null checks with the IsEmpty property for ReadOnlySpan<char> variables to suppress CA2265 warnings. The changes update the LinkHelper.Urilize method to use span-based empty checks instead of null checks.
- Replaces
nullassignment withReadOnlySpan<char>.Emptyfor the normalized variable - Changes null check from
normalized != nullto!normalized.IsEmpty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace null checks with
IsEmptyproperty forReadOnlySpan<char>.The change suppresses CA2265 warnings.