Make it possible to pass functions to be run prior to flushing the response #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy to implement Server timing, which appears in the browser's developer console, as follows:
Ideally, we would do this via HTTP trailers which can be appended to the response, but this only works in Firefox, see https://www.fastly.com/blog/supercharging-server-timing-http-trailers/, so we need a way to append this information at the last moment possible: before finishing sending the headers. This is roughly the equivalent of https://github.com/jshttp/on-headers (see how NuxtJS does this) and intercepting Ktor's send pipeline, see https://ktor.io/docs/server-custom-plugins-base-api.html
For server metrics in ExpressJS, see https://www.npmjs.com/package/server-timing. They add a
setMetric()
method to response. While I don't like monkey-patching, I'd like to have an easy way of adding metrics. Maybe something like this?